From 0d5f1acef1b2e1c9e9248fa52b4af5e77d93b41a Mon Sep 17 00:00:00 2001 From: Eugen Ciur <eugen@papermerge.com> Date: Sat, 2 Oct 2021 07:37:55 +0200 Subject: [PATCH] remove very simple addon dependency --- app/components/tag/table_row.hbs | 3 +-- app/helpers/is_equal.js | 9 +++++++++ app/styles/button.scss | 2 +- app/styles/tag.scss | 10 +++++----- package-lock.json | 9 --------- package.json | 1 - 6 files changed, 16 insertions(+), 18 deletions(-) create mode 100644 app/helpers/is_equal.js diff --git a/app/components/tag/table_row.hbs b/app/components/tag/table_row.hbs index 2721c80..4e27eb2 100644 --- a/app/components/tag/table_row.hbs +++ b/app/components/tag/table_row.hbs @@ -1,5 +1,4 @@ -{{! `eq` helper is provided by ember-truth-helpers addon !}} -{{#if (eq this.edit_mode_id @tag.id)}} +{{#if (is_equal this.edit_mode_id @tag.id)}} {{! inline edit }} <td> <p class="my-2"> diff --git a/app/helpers/is_equal.js b/app/helpers/is_equal.js new file mode 100644 index 0000000..697cfdd --- /dev/null +++ b/app/helpers/is_equal.js @@ -0,0 +1,9 @@ +import { helper } from '@ember/component/helper'; +import { isEqual as emberIsEqual } from '@ember/utils'; + + +export function is_equal([a, b]) { + return emberIsEqual(a, b); +} + +export default helper(is_equal); \ No newline at end of file diff --git a/app/styles/button.scss b/app/styles/button.scss index b567265..0345d18 100644 --- a/app/styles/button.scss +++ b/app/styles/button.scss @@ -1,3 +1,3 @@ button { - border-radius: 0px !important; + border-radius: 0px !important; } \ No newline at end of file diff --git a/app/styles/tag.scss b/app/styles/tag.scss index 3c1e07c..e5d1733 100644 --- a/app/styles/tag.scss +++ b/app/styles/tag.scss @@ -1,10 +1,10 @@ .tag { - span { - padding: 0.35rem; - border-radius: 0.25rem; - } + span { + padding: 0.35rem; + border-radius: 0.25rem; + } } .tag-link { - text-decoration: none; + text-decoration: none; } \ No newline at end of file diff --git a/package-lock.json b/package-lock.json index 039fd3e..746a878 100644 --- a/package-lock.json +++ b/package-lock.json @@ -11174,15 +11174,6 @@ } } }, - "ember-truth-helpers": { - "version": "3.0.0", - "resolved": "https://registry.npmjs.org/ember-truth-helpers/-/ember-truth-helpers-3.0.0.tgz", - "integrity": "sha512-hPKG9QqruAELh0li5xaiLZtr88ioWYxWCXisAWHWE0qCP4a2hgtuMzKUPpiTCkltvKjuqpzTZCU4VhQ+IlRmew==", - "dev": true, - "requires": { - "ember-cli-babel": "^7.22.1" - } - }, "ember-welcome-page": { "version": "4.1.0", "resolved": "https://registry.npmjs.org/ember-welcome-page/-/ember-welcome-page-4.1.0.tgz", diff --git a/package.json b/package.json index 57a2ce3..2efb9a6 100644 --- a/package.json +++ b/package.json @@ -51,7 +51,6 @@ "ember-resolver": "^8.0.2", "ember-source": "~3.28.0", "ember-template-lint": "^3.6.0", - "ember-truth-helpers": "^3.0.0", "ember-welcome-page": "^4.0.0", "eslint": "^7.32.0", "eslint-config-prettier": "^8.3.0", -- GitLab